Review Request: ktouch: require at least KDE SC 4.10 RC 1 libaries
Albert Astals Cid
tsdgeos at terra.es
Sat Dec 29 15:19:12 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107999/#review24184
-----------------------------------------------------------
Ship it!
If you don't mind that using your app will be "impossible" for people using 4.9 i don't think the release-team should have any complaint against that either.
- Albert Astals Cid
On Dec. 29, 2012, 11:42 a.m., Sebastian Gottfried wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107999/
> -----------------------------------------------------------
>
> (Updated Dec. 29, 2012, 11:42 a.m.)
>
>
> Review request for Release Team.
>
>
> Description
> -------
>
> Up to now I was requiring the last released version of the KDE SC to build KTouch, but behavioral changes to the Plasma QML components introduced in this development cycle make this impossible. Now it's impossible to get pixel perfect results on both 4.9 and 4.10. Obviously I'm focusing on 4.10 as this is the version KTouch is released with. Additionally I introduced accidentally a real dependency on 4.10 when fixing the issues I had with the new Plasma QML components version by using some newly introduced properies. I could theoretically revert these changes, but it would result in less than pixel-perfect results.
>
>
> Diffs
> -----
>
> CMakeLists.txt e370126
>
> Diff: http://git.reviewboard.kde.org/r/107999/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Sebastian Gottfried
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20121229/e865870a/attachment.html>
More information about the release-team
mailing list