QUrl and knotify (Re: KDE 4.8 RC1 (4.7.95) tarballs uploaded (try#1))

[David Faure]

On Monday 26 December 2011 19:42:17 Rex Dieter wrote:
> Phil Miller wrote:
> > KDE has some issues with qt-4.8.0.
> > 
> > One of it is regarding QUrl.toLocalfile:
> > 
> > https://bugzilla.redhat.com/show_bug.cgi?id=749213
> 
> probably of more interest is following these,
> https://bugreports.qt.nokia.com//browse/QTBUG-22382
> and it's impact on kde:
> http://bugs.kde.org/show_bug.cgi?id=285028
> 
> > Patching qt with followed patch fixes it:
> > 
> > qt-everywhere-opensource-src-4.8.0-QUrl_toLocalFile.patch
> 
> Not exactly "fix", but more of a workaround to restore qt47 behavior in the
> meantime.

Right. The real fix is to fix knotify, which was doing this rather wrong ("if 
isRelative then call toLocalFile").

Actually the guilty commit is probably the one which replaced most calls to 
path() by calls to toLocalFile() in order to fix local file paths on Windows.

So a solution could be to just put path() back.
An alternative is the patch I now posted to bug 285028.
Can you test either one (should be equivalent) and apply that if it works?

I don't think patching Qt is a good idea at all, it makes qt-4.8 different from 
qt-4.8 depending on the system, which creates a support hell.

And to reassure you, the amount of toLocalFile() calls over all doesn't 
matter, 99.99% of the urls used in KDE are absolute, not relative.

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5