KDE 4.5.0 tagged (1st try of tarballs uploaded)

[Raphael Kubo da Costa]

On Friday 30 July 2010 17:25:48 Sebastian Kügler wrote:
> Hi Max,
> 
> Thanks for the report. See my answer below.
> 
> On Friday 30 July 2010
> 
> 21:33:58 Max Brazhnikov wrote:
> > On Thu, 29 Jul 2010 14:09:45 +0200, Dirk
> 
> Mueller wrote:
> > > Hi,
> > > 
> > > I just finished uploading the first set of
> 
> KDE 4.5.0 tarballs to
> 
> > > stable/4.5.0/src. Please let me know of any
> 
> blocking issues (JRiddels
> 
> > > PyQt 4.7 fix is not yet included I believe).
> > > 
> > > 
> > > kde-l10n tarballs are still building.
> > 
> > workspace fails to build
> 
> for me with Qt-4.6.3 and
> 
> > gcc version 4.2.1 20070719  [FreeBSD]:
> > 
> > [
> 
> 77%] Building CXX object
> 
> plasma/netbook/shell/CMakeFiles/kdeinit_plasma-netbook.dir/netcorona.o cd
> 
> /work/a/ports/x11/kdebase4-workspace/work/kdebase-workspace-4.5.0/build/pl
> 
> asma/netbook/shell && /opt/c++   -Dkdeinit_plasma_netbook_EXPORTS
> 
> -D_GNU_SOURCE -DQT_NO_STL -DQT_NO_CAST_TO_ASCII -D_REENTRANT
> 
> -DKDE_DEPRECATED_WARNINGS -DHAVE_CONFIG_H=1 -DKDE_DEFAULT_DEBUG_AREA=1204
> 
> -O2 -pipe -fno-strict-aliasing -Woverloaded-virtual -fvisibility=hidden
> 
> -fvisibility-inlines-hidden -O2 -DNDEBUG -DQT_NO_DEBUG -fPIC
> 
> -I/work/a/ports/x11/kdebase4-workspace/work/kdebase-workspace-4.5.0/build/
> 
> plasma/netbook/shell
> 
> -I/work/a/ports/x11/kdebase4-workspace/work/kdebase-workspace-4.5.0/plasma
> 
> /netbook/shell
> 
> -I/work/a/ports/x11/kdebase4-workspace/work/kdebase-workspace-4.5.0
> 
> -I/work/a/ports/x11/kdebase4-workspace/work/kdebase-workspace-4.5.0/build
> 
> -I/work/a/ports/x11/kdebase4-workspace/work/kdebase-workspace-4.5.0/kdm
> 
> -I/work/a/ports/x11/kdebase4-workspace/work/kdebase-workspace-4.5.0/libs
> 
> -I/work/a/ports/x11/kdebase4-workspace/work/kdebase-workspace-4.5.0/libs/k
> 
> workspace
> 
> -I/work/a/ports/x11/kdebase4-workspace/work/kdebase-workspace-4.5.0/libs/p
> 
> lasmagenericshell
> 
> -I/work/a/ports/x11/kdebase4-workspace/work/kdebase-workspace-4.5.0/plasma
> 
> /netbook/shell/scripting
> 
> -I/work/a/ports/x11/kdebase4-workspace/work/kdebase-workspace-4.5.0/libs/k
> 
> ephal -I/usr/local/kde4/include -I/usr/local/kde4/include/KDE
> 
> -I/usr/local/include/qt4/phonon -I/usr/local/include/qt4/QtXmlPatterns
> 
> -I/usr/local/include/qt4/QtXml -I/usr/local/include/qt4/QtWebKit
> 
> -I/usr/local/include/qt4/QtUiTools -I/usr/local/include/qt4/QtTest
> 
> -I/usr/local/include/qt4/QtSvg -I/usr/local/include/qt4/QtSql
> 
> -I/usr/local/include/qt4/QtScriptTools -I/usr/local/include/qt4/QtScript
> 
> -I/usr/local/include/qt4/QtOpenGL -I/usr/local/include/qt4/QtNetwork
> 
> -I/usr/local/include/qt4/QtHelp -I/usr/local/include/qt4/QtDesigner
> 
> -I/usr/local/include/qt4/QtDBus -I/usr/local/include/qt4/Qt3Support
> 
> -I/usr/local/include/qt4/QtGui -I/usr/local/include/qt4/QtCore
> 
> -I/usr/local/include/qt4/Qt -I/usr/local/share/qt4/mkspecs/default
> 
> -I/usr/local/include/qt4 -I/usr/local/include   -o
> 
> CMakeFiles/kdeinit_plasma-netb ook.dir/netcorona.o -c
> 
> /work/a/ports/x11/kdebase4-workspace/work/kdebase-workspace-4.5.0/plasma/n
> 
> etbook/shell/netcorona.cpp /usr/local/kde4/include/kconfig.h: In member
> 
> function 'virtual void NetCorona::loadDefaultLayout()':
> 
> /usr/local/kde4/include/kconfig.h:400: error: 'KConfig::KConfig(const
> 
> KConfig&)' is private
> 
> /work/a/ports/x11/kdebase4-workspace/work/kdebase-workspace-4.5.0/plasma/n
> 
> etbook/shell/netcorona.cpp:85: error: within this context gmake[2]: ***
> 
> [plasma/netbook/shell/CMakeFiles/kdeinit_plasma-netbook.dir/netcorona.o]
> 
> Error 1 gmake[2]: Leaving directory
> 
> `/work/a/ports/x11/kdebase4-workspace/work/kdebase-workspace-4.5.0/build'
> 
> gmake[1]: ***
> 
> [plasma/netbook/shell/CMakeFiles/kdeinit_plasma-netbook.dir/all] Error 2
> 
> gmake[1]: Leaving directory
> 
> `/work/a/ports/x11/kdebase4-workspace/work/kdebase-workspace-4.5.0/build'
> 
> gmake: *** [all] Error 2
> 
> > *** Error code 1
> > 
> > Any idea?
> > 
> > Max
> 
> I (and
> with that I mean notmart who's just looked into this) don't understand
> this, the code is not calling KConfig::KConfig(const KConfig&), but
> KConfig::KConfig(QString). Apparently your compiler thinks differently, and
> I wonder why. Anybody else maybe?

I get the same compilation problem with trunk here on FreeBSD, gcc 4.2.1 as 
well.

After playing around with the code and writing a small testcase, SadEagle gave 
me a hand on IRC and it looks like it was a gcc bug [1][2] which was fixed on 
the 4.3.0 release.

A workaround is to simply create the KConfig object before calling 
importLayout(), so that it is not passed as a temporary. I've committed 
revisions 1157732 (trunk) and 1157733 (4.5 branch) which fix the reported 
issue.

[1] http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36490
[2] http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25950

Cheers,
Raphael