Freeze exemption for PA integration into Phonon

Colin Guthrie cguthrie at mandriva.org
Fri Nov 20 10:06:08 CET 2009


'Twas brillig, and Christoph Feck at 20/11/09 01:55 did gyre and gimble:
> Building kdebase r1051746 with kdesupport r1051730 I get the following error 
> in kdebase:
> 
> /local/svn/kde/trunk/KDE/kdebase/runtime/phonon/kcm/devicepreference.cpp: In 
> member function 'void DevicePreference::load()':
> /local/svn/kde/trunk/KDE/kdebase/runtime/phonon/kcm/devicepreference.cpp:330: 
> error: 'class Phonon::GlobalConfig' has no member named 
> 'getHideAdvancedDevices'
> /local/svn/kde/trunk/KDE/kdebase/runtime/phonon/kcm/devicepreference.cpp: In 
> member function 'void DevicePreference::on_showCheckBox_toggled()':
> /local/svn/kde/trunk/KDE/kdebase/runtime/phonon/kcm/devicepreference.cpp:548: 
> error: no matching function for call to 
> 'Phonon::GlobalConfig::hideAdvancedDevices(bool)'
> /local/kde4/include/phonon/globalconfig.h:51: note: candidates are: bool 
> Phonon::GlobalConfig::hideAdvancedDevices() const
> make[2]: *** [runtime/phonon/kcm/CMakeFiles/kcm_phonon.dir/devicepreference.o] 
> Error 1
> make[2]: Target `runtime/phonon/kcm/CMakeFiles/kcm_phonon.dir/build' not 
> remade because of errors.
> make[1]: *** [runtime/phonon/kcm/CMakeFiles/kcm_phonon.dir/all] Error 2


Gah, Sorry about that. This was a cleanup change from Matthias that 
looked harmless when I reviewed it (I thought these were left over APIs 
I'd defined during a failed part of the process but forgotten to remove).

Phonon trunk should have them exported again.

Thanks also to mpyne who tweaked the cmake file. I originally copied 
this from one of the other KDE packages but due to git-svn it didn't 
mark it as an svn cp... I should make sure that these files are kept in 
sync or that the FindPulseAudio.cmake is moved to somewhere central... 
any suggestions?

Col

-- 

Colin Guthrie
cguthrie(at)mandriva.org
http://colin.guthr.ie/

Day Job:
   Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
   Mandriva Linux Contributor [http://www.mandriva.com/]
   PulseAudio Hacker [http://www.pulseaudio.org/]
   Trac Hacker [http://trac.edgewall.org/]


More information about the release-team mailing list