BC problem in kdepimlibs/kcal/calendarresources.cpp

[Tom Albers]

Op Saturday 21 March 2009 18:55 schreef u:
> Op Saturday 21 March 2009 18:16 schreef u:
> > Op Friday 20 March 2009 13:19 schreef u:
> > > Hi,
> > > 
> > > In commit 926668 to trunk/KDE/kdepimlibs/kcal/calendarresources.cpp I 
> > > accidentally broke binary compatibility.
> > > 
> > > This commit was back ported to branch 4.2 and is present in KDE4.2.1.
> > > 
> > > Now I fixed it so it's BC with 4.0, 4.1, 4.2.{0, 2, ...}, 4.3 ... just not 
> > > 4.2.1 :(
> > > 
> > > Commits which broke BC are:
> > > trunk - 926668
> > > branch4.2 - 926671
> > > 
> > > Commits which fixed BC are:
> > > trunk - 941693
> > > branch4.2 - 941695
> > > 
> > > 
> > > 
> > > I apologize for any inconvenience. 
> > 
> > Hi,
> > 
> > Those things happen. 
> > 
> > But although the damage has been repaired, it leaves us with a 4.2.2 which
> will
> > be BIC against 4.2.1. So I think we *must* bump the so-version now.
> > 
> > Toma
> 
> Actually it is about a boolean added to the .h, which is not BIC. Removing it
> for 4.2.2 would be.
> 
> If this is correct, I suggest to re-add a dummy bool, with a comment to remove
> that for kde5.
> 
> Best,
> 
> Toma

This is not correct, it was bic. People on irc tell me to not bump so for this. 
So, lets leave it as is. Sorry for the noise...

Toma