Fwd: Re: kdesupport/strigi/src/streams

[Tom Albers]

Hi,

As this seems to hit quite a few people, we might want a fix for this before Dirk tags rc1.

Toma

Op maandag 07 juli 2008 11:30 schreef Peter Penz <peter.penz at gmx.at>:
> Hi Jos,
> 
> On Monday, 7. July 2008 10:57:45 jos at vandenoever.info wrote:
> > Hi Peter,
> >
> > I'd appreciate if you can fix the CMakeLists.txt, since I cannot do this
> > from work (the next 6 hours).
> 
> I've disabled avithroughanalyzer.cpp in CMakeLists.txt - I did a recompile of 
> kdesupport + kdelibs, but the crash in bug 164296 still occurs.
> 
> I've to go to the office now and won't have SVN access during the next 
> hours -> I'm not sure whether it's just a local problem or whether there is 
> another analyzer which makes problems too (I've done the test with the 
> attachment provided in 164296).
> 
> Cheers,
> Peter
> 
> >
> > Cheers,
> > Jos
> >
> > On Mon, 07 Jul 2008 08:25:57 +0000, Peter Penz <peter.penz at gmx.at> wrote:
> > > SVN commit 829008 by ppenz:
> > >
> > > Fixed possible crash when getting the meta information from files (thanks
> > > to Jakub Stachowski for the patch!).
> > >
> > > @Jos: RC1 will be tagged tomorrow. I applied the patch as this is a
> > > showstopper for Dolphin (got already 20 bug reports because of this
> >
> > during
> >
> > > the last 2 weeks) and I guess you are on vacation currently (no SVN
> >
> > commit
> >
> > > since one month) - I hope this is OK for you!
> > >
> > > CCMAIL: jos at vandenoever.info
> > > BUG: 164296
> > >
> > >  M  +2 -0      bufferedstream.h
> > >
> > >
> > > --- trunk/kdesupport/strigi/src/streams/bufferedstream.h #829007:829008
> > > @@ -172,6 +172,8 @@
> > >          buffer.avail += (int32_t)d;
> > >          buffer.readPos -= d;
> > >          StreamBase<T>::m_status = Ok;
> > > +    } else if (newpos == 0) {
> > > +        resetBuffer();
> > >      }
> > >      return StreamBase<T>::m_position;
> > >  }