KDE/kdelibs

[David Faure]

On Wednesday 05 December 2007, Thomas Zander wrote:
> On Tuesday 4. December 2007 19:38:07 Dirk Mueller wrote:
> > On Monday 03 December 2007, Hamish Rodda wrote:
> > > Replace KAction::associateWidget() with a set of methods to permanently
> > > associate / dissociate a widget with an action collection.  This does not
> > > change the shortcut context, in contrast to the methods that I removed
> > > about a month ago; this approach was thought to be ok (in comparison to
> > > the one I removed) because it does not cause modification of the actions
> > > being added to the collection.
> > >
> > > Also, add all xmlgui client actions to the top level main window.
> > >
> > > These two changes fix bug 151421 and duplicates / related bugs.
> > >
> > > It is BIC as I have removed the old associateWidget(), for which I will
> > > commit patches to the rest of KDE which use it now.
> >
> > even worse, it is source incompatible. Did you notice that we have released
> > a stable platform that is now broken again?
> >
> > can the associateWidget() call be restored?
> 
> Would be nice if this was replied to his repeated requests for feedback on 
> k-c-d where he pointed out the incompatibility. :(

Yes.

> Since it didn't, and he fixed all of kde-svn, I'm not particularly in favor of 
> the requested revert...

I didn't revert; I simply re-added a method with the old name [and almost but
not exactly the old behavior; a better behavior].

I didn't mark it as DEPRECATED because it actually does something useful now
(as a convenience method).

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).