[rekonq] Review Request 120102: Restore Internal ID for History Models

Andrea Diamantini adjam7 at gmail.com
Tue Sep 9 21:45:02 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120102/#review66159
-----------------------------------------------------------

Ship it!


Ship It!

- Andrea Diamantini


On Sept. 8, 2014, 4:09 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120102/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2014, 4:09 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Bugs: 338664
>     /show_bug.cgi?id=338664
> 
> 
> Repository: rekonq
> 
> 
> Description
> -------
> 
> These were removed for some unknown reason and were causing crashes.
> 
> 
> Diffs
> -----
> 
>   src/history/historymodels.cpp 454fe5c 
> 
> Diff: https://git.reviewboard.kde.org/r/120102/diff/
> 
> 
> Testing
> -------
> 
> Before this patch, rekonq would crash as soon as the history model was queried, see bug report. Now rekonq does not crash.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20140909/5ac11be5/attachment.html>


More information about the rekonq mailing list