[rekonq] Review Request 115161: fix highlighting in the completion widget

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115161/#review47906
-----------------------------------------------------------


Add also some comments before the code line, please. Otherwise, it will seem dark magic... :)

- Andrea Diamantini


On Jan. 20, 2014, 9:29 p.m., Mathias Kraus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115161/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2014, 9:29 p.m.)
> 
> 
> Review request for rekonq and Andrea Diamantini.
> 
> 
> Repository: rekonq
> 
> 
> Description
> -------
> 
> when typing in the urlbar the first item ist not highlighted after the second letter.
> 
> due to the change in commit f0b2b230e1cd4d35f2a95c3bad94e31ecdd70de1 the widgets in the completion list are not deleted immediatelly.
> when trying to highlight the widget at index 0, a search for the widget with the object name "0" is done, but because the widget might not be deleted, the old widget with the object name "0" will be found.
> 
> this patch sets the object name of the widget to "old" + index in the list, befor calling deleteLater().
> when new suggestions are added to the list, there will be only one with the name "0", even if the old ones are not yet deleted.
> 
> 
> Diffs
> -----
> 
>   src/urlbar/completionwidget.cpp 51ebd9e 
> 
> Diff: https://git.reviewboard.kde.org/r/115161/diff/
> 
> 
> Testing
> -------
> 
> compiled and checked if the highlighting works again
> 
> 
> Thanks,
> 
> Mathias Kraus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20140121/7fd3a1fe/attachment.html>