[rekonq] Review Request 109613: Save your browsing sessions with rekonq

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109613/#review30156
-----------------------------------------------------------



src/history/historymanager.h
<http://git.reviewboard.kde.org/r/109613/#comment22459>

    why this? Are you aware this will completely break previous history?



src/sessionmanager.h
<http://git.reviewboard.kde.org/r/109613/#comment22455>

    indentation



src/sessionmanager.cpp
<http://git.reviewboard.kde.org/r/109613/#comment22456>

    pass by value



src/sessionmanager.cpp
<http://git.reviewboard.kde.org/r/109613/#comment22458>

    well... logic here is tricky. You cannot think people is going to save yourself their session



src/sessionmanager.cpp
<http://git.reviewboard.kde.org/r/109613/#comment22457>

    pass by value



src/webwindow/webwindow.cpp
<http://git.reviewboard.kde.org/r/109613/#comment22460>

    wrong icons



src/webwindow/webwindow.cpp
<http://git.reviewboard.kde.org/r/109613/#comment22461>

    wrong icon



src/webwindow/webwindow.cpp
<http://git.reviewboard.kde.org/r/109613/#comment22462>

    what if people wanna open a web resource instead?


- Andrea Diamantini


On March 20, 2013, 4:54 p.m., mayank jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109613/
> -----------------------------------------------------------
> 
> (Updated March 20, 2013, 4:54 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> A patch which allows you to save and later reload your important browsing sessions!
> 
> 
> Diffs
> -----
> 
>   src/history/historymanager.h a618c67 
>   src/history/historymanager.cpp 2fab9cf 
>   src/sessionmanager.h 6d6bef2 
>   src/sessionmanager.cpp 8c78172 
>   src/webwindow/rekonqui.rc 90c5c19 
>   src/webwindow/webwindow.h b2e0f5a 
>   src/webwindow/webwindow.cpp 1225fb0 
> 
> Diff: http://git.reviewboard.kde.org/r/109613/diff/
> 
> 
> Testing
> -------
> 
> works fine!
> 
> 
> Thanks,
> 
> mayank jha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20130330/c61385d2/attachment.html>