[rekonq] Review Request 111567: Reduce the auto-scroll timer interval

Andrea Diamantini adjam7 at gmail.com
Mon Jul 29 08:41:53 UTC 2013



> On July 29, 2013, 8:16 a.m., Andrea Diamantini wrote:
> > Ship It!

Please, let me know if you need help to properly merge this!


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111567/#review36707
-----------------------------------------------------------


On July 18, 2013, 1:09 p.m., Diego Soenens wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111567/
> -----------------------------------------------------------
> 
> (Updated July 18, 2013, 1:09 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> The current m_autoScrollTimer interval of 100ms (10 FPS!) makes auto-scrolling feel sluggish and unresponsive.
> IMHO it should have the same interval as m_smoothScrollTimer (16ms) so that it feels smooth and responsive.
> 
> 
> Diffs
> -----
> 
>   src/webtab/webview.cpp ce3f5a9 
> 
> Diff: http://git.reviewboard.kde.org/r/111567/diff/
> 
> 
> Testing
> -------
> 
> Works perfectly on my system. CPU usage while auto-scrolling doesn't change any more than it does while just scrolling with smooth scrolling enabled.
> 
> 
> Thanks,
> 
> Diego Soenens
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20130729/80559cc8/attachment.html>


More information about the rekonq mailing list