[rekonq] Review Request 111521: Adding domain-specific hiding support to the adblocker
Paul Rohrbach
p.b.r at gmx.net
Mon Jul 15 14:10:28 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111521/
-----------------------------------------------------------
Review request for rekonq.
Description
-------
Adding domain-specific hiding support to the adblocker.
The domain-specific rules are stored in a QMultiHash, where the key is the domain and the values are the rules for the specified domain. This causes redundancy, because on rule can be applied to more than one domain, but has a really fast look-up time. The code for the generic hiding has not changed and is just relocated.
Diffs
-----
src/CMakeLists.txt c749a69
src/adblock/adblockelementhiding.h PRE-CREATION
src/adblock/adblockelementhiding.cpp PRE-CREATION
src/adblock/adblockmanager.h 3d329ad
src/adblock/adblockmanager.cpp 51000a3
Diff: http://git.reviewboard.kde.org/r/111521/diff/
Testing
-------
- it hides things
- it is reasonably fast (generic hiding takes with my configuration 300-500ms, the domain-specific hiding only takes 30-70µs)
Thanks,
Paul Rohrbach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20130715/9f09407d/attachment.html>
More information about the rekonq
mailing list