[rekonq] Review Request 108526: Option for where new tabs are added

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108526/#review26073
-----------------------------------------------------------

Ship it!


out of curiosity... I checked Qt code to see the difference between insertTab && addTab. Here is how addTab is defined:
int QTabWidget::addTab(QWidget *child, const QString &label)
{
    return insertTab(-1, child, label);
}
So, let's save a count() call and merge it :)

- Andrea Diamantini


On Jan. 23, 2013, 10:51 a.m., Lindsay Mathieson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108526/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2013, 10:51 a.m.)
> 
> 
> Review request for rekonq and Lindsay Mathieson.
> 
> 
> Description
> -------
> 
> Added option for opening new tabs next to current (default to true). Otherwise tabs created at end of list.
> 
> 
> Diffs
> -----
> 
>   src/rekonq.kcfg 0e083ed 
>   src/settings/settings_tabs.ui df6db9b 
>   src/tabwindow/rekonqwindow.cpp 1717403 
> 
> Diff: http://git.reviewboard.kde.org/r/108526/diff/
> 
> 
> Testing
> -------
> 
> Opened new tabs with option on/off
> 
> 
> Thanks,
> 
> Lindsay Mathieson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20130123/ad3aab35/attachment.html>