[rekonq] Review Request: Restore Tab Windows when Restoring the Session

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108077/#review24849
-----------------------------------------------------------


Seems good. Just give me a bit more time to properly test it.

- Andrea Diamantini


On Jan. 2, 2013, 1 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108077/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2013, 1 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> Modify the restore method so that it returns true in case something is actually restored, and then use that return value to call the restoreTabWindow method of the session manager
> 
> 
> Diffs
> -----
> 
>   src/main.cpp 7f6fcd9 
>   src/tabwindow/rekonqwindow.cpp afebf79 
> 
> Diff: http://git.reviewboard.kde.org/r/108077/diff/
> 
> 
> Testing
> -------
> 
> 1. Load several rekonq windows across several activities
> 2. Log out
> 3. Log back in
> 
> Before this patch, windows would be restored with blank tabs in them. After this patch, the old tabs are also restored.
> 
>  I had to manually "sync" mi session XML with the session config for rekonq so that window object names would match, but I think that hack was related to other kinds of errors.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20130106/520eba03/attachment.html>