[rekonq] Review Request 108801: rekonq: Open new tabs in the foreground

[Dimitrios Christidis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108801/
-----------------------------------------------------------

(Updated Feb. 10, 2013, 1:33 p.m.)


Review request for rekonq and Dimitrios Christidis.


Changes
-------

Reverted the setting's logic.


Description
-------

Adds a new configuration option (disabled by default) to open links in new tabs in the foreground.


This addresses bug 313794.
    /show_bug.cgi?id=313794


Diffs (updated)
-----

  src/rekonq.kcfg 6303dcd 
  src/settings/settings_tabs.ui 5b367a8 
  src/tabwindow/tabwindow.cpp d0e6dbc 

Diff: http://git.reviewboard.kde.org/r/108801/diff/


Testing
-------

There are multiple calls to TabWindow::loadUrl() with Rekonq::NewTab, but I think I got them all. Tested with the new setting enabled and disabled.

+ click on link with middle mouse button
+ right-click on link, then open in new tab
+ same actions on the bookmarks toolbar and about: pages
+ right-click on image, middle-click on "View Image"

Loading an external URL always focuses the new tab. Same with middle-clicking on a link in the search bar.


Thanks,

Dimitrios Christidis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20130210/4a0e30da/attachment.html>