[rekonq] Review Request 108729: Restores bookmark menu

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108729/#review26628
-----------------------------------------------------------


First, I have a problem executing this code:
Object::connect: No such slot BookmarkMenu::actionHovered() in /SW/SRC/rekonq/src/bookmarks/bookmarkstoolbar.cpp:97

Second, I propose to change actual code a bit: move management actions up and do something like this:

add bookmark
bookmark tabs as folder
--- separator ---
bookmark page
bookmark toolbar
edit bookmarks
--- separator ---
[the bookmarks]

This way we can merge this kactionmenu with the one in rekonq tools menu and easy code management.

- Andrea Diamantini


On Feb. 3, 2013, 10:13 a.m., Lindsay Mathieson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108729/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2013, 10:13 a.m.)
> 
> 
> Review request for rekonq, Andrea Diamantini and Lindsay Mathieson.
> 
> 
> Description
> -------
> 
> Restores the bookmark menu from 1.3
> 
> 
> Diffs
> -----
> 
>   src/bookmarks/bookmarkmanager.h c970d39 
>   src/bookmarks/bookmarkmanager.cpp 30a7772 
>   src/webwindow/webwindow.cpp 59c8757 
> 
> Diff: http://git.reviewboard.kde.org/r/108729/diff/
> 
> 
> Testing
> -------
> 
> Added/removed bookmark menu to main toolbar.
> Checked bookmarks dropped down as expected
> Opened bookmarks
> Edited Bookmarks
> Deleted Bookmarks
> Saved Tabs as Group
> Added bookmarks
> 
> 
> Thanks,
> 
> Lindsay Mathieson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20130204/e3856c8c/attachment.html>