[rekonq] Review Request 109854: This fixes the cluttering of tabs after pinned tabs are unpinned!
Andrea Diamantini
adjam7 at gmail.com
Tue Apr 23 15:01:32 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109854/#review31454
-----------------------------------------------------------
I tested this and I don't have any sort of gain from. Or at least the "cluttering" in my pinned/unpinned tab (half icon shown) is not removed.
- Andrea Diamantini
On April 8, 2013, 6:59 a.m., mayank jha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109854/
> -----------------------------------------------------------
>
> (Updated April 8, 2013, 6:59 a.m.)
>
>
> Review request for rekonq.
>
>
> Description
> -------
>
> Just changed the position of setTabData(false); in the function unpinTab() to a position similar as in pinTab()
>
>
> This addresses bug 317798.
> /show_bug.cgi?id=317798
>
>
> Diffs
> -----
>
> src/tabwindow/tabbar.cpp 7363d96
>
> Diff: http://git.reviewboard.kde.org/r/109854/diff/
>
>
> Testing
> -------
>
> Tests done and it works fine!!
>
>
> Thanks,
>
> mayank jha
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20130423/ef68042e/attachment.html>
More information about the rekonq
mailing list