[rekonq] Review Request 109854: This fixes the cluttering of tabs after pinned tabs are unpinned!

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109854/#review30598
-----------------------------------------------------------


Are you kidding?? You just NOT moved setTabData call. You also commented out something else and you broke the whole slot. Again, your code is broken and your tests are not enough. And this is a 3 lines of code patch. Mayank, are you planning to improve your attention and the quality of your patches or thinking to continue this way? How do you think I can feel seeing your next review request coming?

- Andrea Diamantini


On April 4, 2013, 2:56 p.m., mayank jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109854/
> -----------------------------------------------------------
> 
> (Updated April 4, 2013, 2:56 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> Just changed the position of setTabData(false); in the function unpinTab() to a position similar as in pinTab()
> 
> 
> This addresses bug 317798.
>     /show_bug.cgi?id=317798
> 
> 
> Diffs
> -----
> 
>   src/tabwindow/tabbar.cpp 7363d96 
> 
> Diff: http://git.reviewboard.kde.org/r/109854/diff/
> 
> 
> Testing
> -------
> 
> Tests done and it works fine!!
> 
> 
> Thanks,
> 
> mayank jha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20130407/f7354f2d/attachment.html>