[rekonq] Review Request 109613: Save your browsing sessions with rekonq

[Andrea Diamantini]

> On March 30, 2013, 5:25 p.m., Andrea Diamantini wrote:
> > src/sessionmanager.cpp, line 165
> > <http://git.reviewboard.kde.org/r/109613/diff/1/?file=120604#file120604line165>
> >
> >     pass by value
> 
> mayank jha wrote:
>     did not get, what was intended?

well... this is basic C++ programming. It's usual better passing parameteres as const references.


> On March 30, 2013, 5:25 p.m., Andrea Diamantini wrote:
> > src/webwindow/webwindow.cpp, line 762
> > <http://git.reviewboard.kde.org/r/109613/diff/1/?file=120607#file120607line762>
> >
> >     what if people wanna open a web resource instead?
> 
> mayank jha wrote:
>     Again, I did not get your point, as it is just a text ?

Mayank, how can I explain this? the fileOpen slot is there to let people open web resources. It was NOT unused code. If you need a slot to open a session file, you have to implement yourself.


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109613/#review30156
-----------------------------------------------------------


On April 1, 2013, 5:59 p.m., mayank jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109613/
> -----------------------------------------------------------
> 
> (Updated April 1, 2013, 5:59 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> A patch which allows you to save and later reload your important browsing sessions!
> 
> 
> Diffs
> -----
> 
>   src/webwindow/webwindow.cpp 1225fb0 
>   src/webwindow/webwindow.h b2e0f5a 
>   src/webwindow/rekonqui.rc 90c5c19 
>   src/sessionmanager.cpp 8c78172 
>   src/sessionmanager.h 6d6bef2 
> 
> Diff: http://git.reviewboard.kde.org/r/109613/diff/
> 
> 
> Testing
> -------
> 
> works fine!
> 
> 
> Thanks,
> 
> mayank jha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20130401/32483ca6/attachment.html>