[rekonq] Review Request: Check if URL is Valid Before Checking if it's about: Protocol
Commit Hook
null at kde.org
Wed Sep 26 11:40:07 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106561/#review19451
-----------------------------------------------------------
This review has been submitted with commit a22c9cbaf7fb0a995c1d89371d2d679e3fd1b3c7 by David E. Narváez to branch master.
- Commit Hook
On Sept. 25, 2012, 4:46 a.m., David Narváez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106561/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2012, 4:46 a.m.)
>
>
> Review request for rekonq.
>
>
> Description
> -------
>
> Check if the URL of the current tab is even valid before checking its protocol. This fixes a bug where a new untitled tab is created on each window but the first one when restoring from a crash (because the initial tab of all windows but the first one have empty URLs).
>
>
> Diffs
> -----
>
> src/sessionmanager.cpp d5bc1ff
>
> Diff: http://git.reviewboard.kde.org/r/106561/diff/
>
>
> Testing
> -------
>
> 1. Open multiple windows in rekonq
> 2. Issue killall rekonq from a console
> 3. Open rekonq again
> 4. Select Yes on the restore a crashed session bar
>
> Before this patch, all windows but the first one would have an untitled empty tab. After this patch the windows are restored just as they were when rekonq crashed.
>
>
> Thanks,
>
> David Narváez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120926/3e25236f/attachment.html>
More information about the rekonq
mailing list