[rekonq] Review Request: Web Comboxes not dropping down when clicked.

[Lindsay Mathieson]

> On Oct. 23, 2012, 4:02 p.m., Andrea Diamantini wrote:
> > Ship It!
> 
> Andrea Diamantini wrote:
>     Uhm... Lindsay, should I take care of the merge job?

And I'm back on track now! Its ok thanks, I'll take care of it


- Lindsay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106952/#review20746
-----------------------------------------------------------


On Oct. 19, 2012, 2:12 p.m., Lindsay Mathieson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106952/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2012, 2:12 p.m.)
> 
> 
> Review request for rekonq, Andrea Diamantini and Lindsay Mathieson.
> 
> 
> Description
> -------
> 
> Fixes problem with Web Comboxes not dropping down when clicked, this was due to not checking the requested creation type in createExtension().
> Removes unneccessary debug output
> 
> 
> Diffs
> -----
> 
>   src/kspellplugin.cpp d25ddf9 
> 
> Diff: http://git.reviewboard.kde.org/r/106952/diff/
> 
> 
> Testing
> -------
> 
> Checked against various websites using webkit 2.3. Checked spell checking works as expected.
> 
> 
> Screenshots
> -----------
> 
> Web Combox Dropdown
>   http://git.reviewboard.kde.org/r/106952/s/787/
> 
> 
> Thanks,
> 
> Lindsay Mathieson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20121024/32a00118/attachment.html>