[rekonq] Review Request: Privacy and Advanced Widget added on settings

Andrea Diamantini adjam7 at gmail.com
Tue Mar 27 07:48:37 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104424/
-----------------------------------------------------------

(Updated March 27, 2012, 7:48 a.m.)


Review request for rekonq.


Description
-------

Clean up (again) rekonq settings, adding "advanced" and "privacy"
sections and removing the "network" one, merged here and there with
the other ones


Get sure settings are updated everytime

Strings, spaces and one unuseful slot removed clean up

clean up failed rebasing and implement history timed expire check

Consider new PasswordSavingEnabled privacy check

Add passwords exceptions management widget

Let settings dialog to be NON modal

Launch proxy, cache, cookies settings as (Q)Process(es)

Tirtha's string suggestion about DNT header settings


Diffs
-----

  src/CMakeLists.txt 10b57b1cbef8884a4b4261fe8000a952a5ff208b 
  src/history/historymanager.cpp 602e46067be18668cafcf25dd1027355342da2e9 
  src/mainwindow.cpp a14f11f020412e54a339d15209917430b1fbd329 
  src/rekonq.kcfg bdcbcb60918dec3fa9659fe0509ee55c327679d6 
  src/settings/advancedwidget.h PRE-CREATION 
  src/settings/advancedwidget.cpp PRE-CREATION 
  src/settings/generalwidget.cpp 226c11c95e44b150e943057f8d2f0ad9a52dd056 
  src/settings/passexceptionswidget.h PRE-CREATION 
  src/settings/passexceptionswidget.cpp PRE-CREATION 
  src/settings/password_exceptions.ui PRE-CREATION 
  src/settings/privacywidget.h PRE-CREATION 
  src/settings/privacywidget.cpp PRE-CREATION 
  src/settings/settings_advanced.ui PRE-CREATION 
  src/settings/settings_appearance.ui 651807b752287297fd74fc35bdb9860ab4927f82 
  src/settings/settings_general.ui 908f1c27341a4497a2d0f62066182dd689bfe2bb 
  src/settings/settings_privacy.ui PRE-CREATION 
  src/settings/settings_webkit.ui 5235eab2c438d24fd2521a05543bcacb077b0ee8 
  src/settings/settingsdialog.h 40a2aeffaf7f36765d904adffb24d710a93d4e8e 
  src/settings/settingsdialog.cpp ef01a32f127672f4ccad550cb3670a12cba96280 
  src/settings/webkitwidget.h 8561d60aee06fe7190c50f6c51423c1c826939b1 
  src/settings/webkitwidget.cpp 0f7a4b3d95e06471c45f077c38ba00a9d6bc5192 
  src/webtab.cpp 8db44dd8065c3deef12f99acb55be5ee3e320b38 

Diff: http://git.reviewboard.kde.org/r/104424/diff/


Testing
-------


Screenshots (updated)
-----------

advanced widget
  http://git.reviewboard.kde.org/r/104424/s/494/


Thanks,

Andrea Diamantini

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120327/e7493291/attachment.html>


More information about the rekonq mailing list