[rekonq] Review Request: Add loadUrl API to mainwindow

Commit Hook null at kde.org
Sun Mar 25 07:26:30 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104326/#review11827
-----------------------------------------------------------


This review has been submitted with commit 2fcbe68fbc19614a053428bdc37d7c6a3c84e8c8 by Andrea Diamantini to branch master.

- Commit Hook


On March 18, 2012, 5:34 a.m., Andrea Diamantini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104326/
> -----------------------------------------------------------
> 
> (Updated March 18, 2012, 5:34 a.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> Add loadUrl API to mainwindow
> 
> - Get rid of unused NewBackTab enum
> - move loading url code to MainWindow class
> - Remove ThreadWeaver API. (And take it easy...)
> - Changed logic: calculate url BEFORE creating a tab...
> 
> 
> Diffs
> -----
> 
>   src/rekonq_defines.h 439ee8cc27a03091683bb3aa0b33fb2cb7170b8e 
>   src/mainwindow.cpp a14f11f020412e54a339d15209917430b1fbd329 
>   src/CMakeLists.txt 10b57b1cbef8884a4b4261fe8000a952a5ff208b 
>   src/adblock/blocked_elements.ui 884daee69cb5618fd8fc13b4e95e56ca1f5548e6 
>   src/application.h 5e07875617bef6eb330eaaad9a19c24906fcb653 
>   src/application.cpp 48fb1a3e0c461475d57e913a6593109111395a95 
>   src/filterurljob.h 20cdd39490c9603a2b940ae09a34db50456a2fa2 
>   src/filterurljob.cpp ff017a073fb6b5acf72e0824fcec51208ee0d472 
>   src/mainview.cpp b164c72bc78baaa3d1539ab5501810213e7d11db 
>   src/mainwindow.h 789c0c1a92443eba9dfc9af668cbd797b9673574 
> 
> Diff: http://git.reviewboard.kde.org/r/104326/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrea Diamantini
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120325/f8a72452/attachment.html>


More information about the rekonq mailing list