[rekonq] Review Request: New History Manager, NO MORE QWebHistoryInterface based.

Andrea Diamantini adjam7 at gmail.com
Sun Mar 18 05:24:33 UTC 2012



> On March 13, 2012, 5:26 p.m., David Narváez wrote:
> > src/history/historymanager.cpp, line 228
> > <http://git.reviewboard.kde.org/r/104257/diff/1/?file=52977#file52977line228>
> >
> >     Do we really want to keep commented code? We can always use VCS history to get these lines if needed.
> 
> Andrea Diamantini wrote:
>     uhm... I just forgot to cancel them. I'll remove this in the next patch.

Fixed with diff 2


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104257/#review11363
-----------------------------------------------------------


On March 18, 2012, 5:23 a.m., Andrea Diamantini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104257/
> -----------------------------------------------------------
> 
> (Updated March 18, 2012, 5:23 a.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> New History Manager, NO MORE QWebHistoryInterface based.
> 
> We are just saving datas on our own, I don't like QtWebKit APIs
> to do it. We now call addHistoryEntry(url, title)
> on loadFinished.
> Data structure will remain the same as usual, but I think API
> is better and data are now saved when we really have them
> ready.
> 
> 
> Diffs
> -----
> 
>   src/webtab.cpp 8db44dd8065c3deef12f99acb55be5ee3e320b38 
>   src/mainview.cpp b164c72bc78baaa3d1539ab5501810213e7d11db 
>   src/protocolhandler.cpp 4744e766bb6d57ff07b8d001d74108e48183f022 
>   src/webtab.h b0c849ef85fd55c17bcc9ba350539752b013af8b 
>   src/history/historymodels.h 9c3bfc365d9fb8ec290ae8ed417e07d236ffe94a 
>   src/history/historymodels.cpp 160540540c1e5925e03541bcd2537ac2a4f9e2dc 
>   src/history/historymanager.h d4531e5cb28ca38f9b9755178b53d4ccb1548db2 
>   src/history/historymanager.cpp 602e46067be18668cafcf25dd1027355342da2e9 
> 
> Diff: http://git.reviewboard.kde.org/r/104257/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrea Diamantini
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120318/7767055f/attachment.html>


More information about the rekonq mailing list