[rekonq] Review Request: Change Bookmark MIME Type and Centralize

David Narváez david.narvaez at computer.org
Fri Mar 16 07:19:04 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104197/
-----------------------------------------------------------

(Updated March 16, 2012, 7:19 a.m.)


Review request for rekonq.


Changes
-------

Sorry, totally forgot to update this patch. It's been hell of a busy week. Fixing all issues raised, and updating to latest master.


Description
-------

As discussed in the mailing list, this changes the MIME type to x-rekonq-bookmark and centralizes all references to that MIME type in one static method.


Diffs (updated)
-----

  src/bookmarks/bookmarkmanager.h 0de128a 
  src/bookmarks/bookmarkstoolbar.cpp fc9a32d 
  src/bookmarks/bookmarkstreemodel.cpp 534e969 
  src/webview.cpp 3d4d7dc 

Diff: http://git.reviewboard.kde.org/r/104197/diff/


Testing
-------

Drag and drop bookmarks to make sure the MIME types are interpreted correctly.

Please notice that this could break any other application that wants to interact with rekonq bookmarks.


Thanks,

David Narváez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120316/83eb464b/attachment.html>


More information about the rekonq mailing list