[rekonq] Review Request: Check if user has a default search engine set and eventually inform and let him set it.

Andrea Diamantini adjam7 at gmail.com
Thu Mar 15 16:55:55 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104290/
-----------------------------------------------------------

(Updated March 15, 2012, 4:55 p.m.)


Review request for rekonq.


Summary (updated)
-----------------

Check if user has a default search engine set and eventually inform and let him set it.


Description (updated)
-------

3 commits to merge:

1---
Check if user has a default search engine set and eventually show a messagewidget to inform and let him set it.


2---
Safe one bool check, everytime a new window is called externally


3---
Fix rekonq exit values, returning ZERO on success
BUG:271442

"newSuggestionBar" branch.


Diffs
-----

  src/CMakeLists.txt 10b57b1cbef8884a4b4261fe8000a952a5ff208b 
  src/application.cpp 48fb1a3e0c461475d57e913a6593109111395a95 
  src/opensearch/opensearchmanager.h 84272f265d2626050e2a5aa291701068a3c72424 
  src/opensearch/opensearchmanager.cpp 12b93ec2870e55fcc6892e0fe71c7fac8ba5e628 
  src/opensearch/searchengine.h 7825d661ba604706938962fd8dd90a3ac508780c 
  src/opensearch/searchengine.cpp b54d94342cded8762ede8c65b5f4ac0fc4057c84 
  src/rekonq.kcfg bdcbcb60918dec3fa9659fe0509ee55c327679d6 
  src/searchenginebar.h PRE-CREATION 
  src/searchenginebar.cpp PRE-CREATION 
  src/webtab.h b0c849ef85fd55c17bcc9ba350539752b013af8b 
  src/webtab.cpp 8db44dd8065c3deef12f99acb55be5ee3e320b38 

Diff: http://git.reviewboard.kde.org/r/104290/diff/


Testing
-------


Thanks,

Andrea Diamantini

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120315/f9d41bee/attachment.html>


More information about the rekonq mailing list