[rekonq] Review Request: Include Tab History when Cloning a Tab

[David Narváez]

> On March 6, 2012, 8:25 a.m., Andrea Diamantini wrote:
> > The code seems ok to me. I just don't understand the need to override the loadUrl method. Are you planning some different use cases for this slot?

The loadUrl slot is connected to many signals in the code, so I didn't want to modify it's signature. I'd guess another way to do this is adding the QWebHistory pointer at the end of the formal parameters of the original slot, whatever's best.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104082/#review11165
-----------------------------------------------------------


On Feb. 26, 2012, 2:31 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104082/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2012, 2:31 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> Implemented through a new loadUrl method that allows for the caller to specify the QWebHistory pointer from where to copy the history. Redirected the original loadUrl slot to use this new method internally. The method returns the WebTab * just in case we need to maninpulate the created tab in the future.
> 
> 
> Diffs
> -----
> 
>   src/application.h 2689e3f 
>   src/application.cpp e0570a5 
>   src/mainview.cpp 19e5531 
> 
> Diff: http://git.reviewboard.kde.org/r/104082/diff/
> 
> 
> Testing
> -------
> 
> 1. Open a tab
> 2. Navigate a couple of pages in the tab
> 3. Clone the tab
> 4. Check the history is preserved in the new tab
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120306/8d0d8b51/attachment.html>