[rekonq] Review Request: fix searchEngine autocompletition

[Andrea Diamantini]

> On July 26, 2012, 8:27 a.m., Andrea Diamantini wrote:
> > I don't understand your changes: this is my kuriikwsfilterrc file.
> > ---
> > [$Version]
> > update_info=kuriikwsfilter.upd:post-kde3.1/cvs
> > 
> > [General]
> > DefaultSearchEngine=google
> > EnableWebShortcuts=true
> > FavoriteSearchEngines=youtube,google,wikipedia,wikit
> > KeywordDelimiter=:
> > UseSelectedProvidersOnly=true
> > ---
> > Moreover, I'm using ArchLinux and search engines are working here.
> > To really fix and improve this code you should REMOVE deprecated access to config file and use KUriFilterData API instead.
> > 
> > The other fix needs to be posted in a different request and just better tested.
> 
> Andrea Diamantini wrote:
>     Moreover, the problem reported here in Chakra (https://bugs.kde.org/show_bug.cgi?id=303872) "autoresolved" itself.
> 
> Johannes Tröscher wrote:
>     yeah :D this is because a chakra-dev (i'm one too) did apply my patch to fix this.this is from the arch-forums: https://bbs.archlinux.org/viewtopic.php?id=145552
>     
>     this is my kuriikwsfilterrc on 4.9 RC:
>     
>     [$Version]
>     update_info=kuriikwsfilter.upd:post-kde3.1/cvs,kuriikwsfilter.upd:pre-kde4.9
>     
>     [General]
>     DefaultWebShortcut=duckduckgo
>     EnableWebShortcuts=true
>     KeywordDelimiter=:
>     PreferredWebShortcuts=youtube,duckduckgo,yahoo,google,wikipedia,wikit
>     UsePreferredWebShortcutsOnly=true
>     
>     ///
>     i'll do another review for the other issue.

Again, your patch is NOT correct, as it surely won't work in KDE SC 4.8.x. In fact, there are arriving some bug reports about search engines in bugzilla against it.
The real solution is to remove the direct access to file and use KUriFilterData API. I'll try to take care about in the morning,


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105732/#review16461
-----------------------------------------------------------


On July 25, 2012, 10:39 p.m., Johannes Tröscher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105732/
> -----------------------------------------------------------
> 
> (Updated July 25, 2012, 10:39 p.m.)
> 
> 
> Review request for rekonq and Andrea Diamantini.
> 
> 
> Description
> -------
> 
> the names of two entries in the code parsing the config file for search engines seem to be wrong. rekonq will not find the default search engine and the favored ones because of this. i've changed the code to use the right entries.
> 
> furthermore there seems to be a bug that causes the completition widget only to be shown from the time on it lost it's focus once and gained it again. i've addressed that as well and changed the code to show the completition widget also on keypress events.i hope that's ok ;)
> 
> bugs occurred in chakra linux and where also confirmed by arch-users.
> 
> 
> This addresses bug 303872.
>     /show_bug.cgi?id=303872
> 
> 
> Diffs
> -----
> 
>   src/opensearch/searchengine.cpp aef06a7 
>   src/urlbar/urlbar.cpp 21debce 
> 
> Diff: http://git.reviewboard.kde.org/r/105732/diff/
> 
> 
> Testing
> -------
> 
> compiles and works
> 
> 
> Thanks,
> 
> Johannes Tröscher
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120727/3c33f583/attachment.html>