[rekonq] Review Request: fix searchEngine autocompletition

Johannes Tröscher fritz_van_tom at hotmail.com
Wed Jul 25 22:39:48 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105732/
-----------------------------------------------------------

Review request for rekonq and Andrea Diamantini.


Description
-------

the names of two entries in the code parsing the config file for search engines seem to be wrong. rekonq will not find the default search engine and the favored ones because of this. i've changed the code to use the right entries.

furthermore there seems to be a bug that causes the completition widget only to be shown from the time on it lost it's focus once and gained it again. i've addressed that as well and changed the code to show the completition widget also on keypress events.i hope that's ok ;)

bugs occurred in chakra linux and where also confirmed by arch-users.


This addresses bug 303872.
    /show_bug.cgi?id=303872


Diffs
-----

  src/opensearch/searchengine.cpp aef06a7 
  src/urlbar/urlbar.cpp 21debce 

Diff: http://git.reviewboard.kde.org/r/105732/diff/


Testing
-------

compiles and works


Thanks,

Johannes Tröscher

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120725/9bf162a2/attachment.html>


More information about the rekonq mailing list