[rekonq] Review Request: Refactor Tab Population

[David Narváez]

> On Jan. 26, 2012, 7:46 a.m., Andrea Diamantini wrote:
> > src/sessionmanager.cpp, line 80
> > <http://git.reviewboard.kde.org/r/103755/diff/1/?file=47672#file47672line80>
> >
> >     Here is the problem. I fear this will let rekonq having one more unuseful tab when restoring crashed sessions (without log out)
> 
> David Narváez wrote:
>     It probably will, but won't this fix belong to another patch? That is, this patch only puts tab filling in a single piece of code you can call whenever you have a MainView pointer and a list of tabs from the session, to avoid code repetition etc, and does not deal with the way MainView pointers are created.
> 
> Andrea Diamantini wrote:
>     No David, I think you missed the point. These 3 pieces of code work differently with the mainview because two of them have a clean mainview (that is with NO tabs at all), while the third has a mainview with ONE tab and it wants to reuse it to show first url

Wow, I totally missed the point in the code and the reviews, I'm very sorry for that. Makes much sense, let me analyze what can be done there and I'll come up with a fixed patch.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103755/#review10087
-----------------------------------------------------------


On Jan. 21, 2012, 6:38 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103755/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2012, 6:38 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> Factor out the code to restore tabs into a main view. This is as much as I think can be factored out of the tab restoration code because, even when each call to restoreTabsInMainView is surrounded by a for loop, each loops has a different way of getting the MainView pointer, but if someone has a better idea I'm open to suggestions.
> 
> 
> Diffs
> -----
> 
>   src/sessionmanager.cpp 74e9603 
> 
> Diff: http://git.reviewboard.kde.org/r/103755/diff/diff
> 
> 
> Testing
> -------
> 
> Usual test cases:
> 1) Crash the session with killall rekonq
> 2) Restore with logout/log back in
> 3) Close windows and restore
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120127/f96f5b0d/attachment-0001.html>