[rekonq] Review Request: Refactor Tab Population

David Narváez david.narvaez at computer.org
Sat Jan 21 18:38:04 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103755/
-----------------------------------------------------------

Review request for rekonq.


Description
-------

Factor out the code to restore tabs into a main view. This is as much as I think can be factored out of the tab restoration code because, even when each call to restoreTabsInMainView is surrounded by a for loop, each loops has a different way of getting the MainView pointer, but if someone has a better idea I'm open to suggestions.


Diffs
-----

  src/sessionmanager.cpp 74e9603 

Diff: http://git.reviewboard.kde.org/r/103755/diff/diff


Testing
-------

Usual test cases:
1) Crash the session with killall rekonq
2) Restore with logout/log back in
3) Close windows and restore


Thanks,

David Narváez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120121/22532da0/attachment.html>


More information about the rekonq mailing list