[rekonq] Review Request: reworking load/stop/reload actions

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103651/#review9779
-----------------------------------------------------------


What about this, guys? I'd like to hear opinions before merge decision.

- Andrea Diamantini


On Jan. 7, 2012, 1:12 p.m., Andrea Diamantini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103651/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2012, 1:12 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> Add load action and merge it with stop/reload.
> 
> Also clean up API, giving proper names to methods:
> - updateActions --> updateHistoryActions
> - browserTabLoading(bool) --> currentTabStateChanged()
> 
> Load state is activated when urlbar got focus.
> 
> 
> Diffs
> -----
> 
>   src/mainview.h 28185e4 
>   src/mainview.cpp 6285159 
>   src/mainwindow.h 04a59a1 
>   src/mainwindow.cpp 98936e9 
>   src/rekonqui.rc 7aeeb56 
>   src/urlbar/urlbar.h 2d158ff 
>   src/urlbar/urlbar.cpp 8368492 
>   src/webpage.cpp 9dee096 
>   src/webtab.h c3d3099 
>   src/webtab.cpp 9516f83 
> 
> Diff: http://git.reviewboard.kde.org/r/103651/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> rekonq load
>   http://git.reviewboard.kde.org/r/103651/s/408/
> rekonq reload
>   http://git.reviewboard.kde.org/r/103651/s/409/
> rekonq stop
>   http://git.reviewboard.kde.org/r/103651/s/410/
> 
> 
> Thanks,
> 
> Andrea Diamantini
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120113/1dd85906/attachment.html>