[rekonq] Review Request: Allows web navigation through keyboard

[Andrea Diamantini]

> On Jan. 10, 2012, 9:48 a.m., Andrea Diamantini wrote:
> > Marc, please cut out the enableViShortcuts change. It is not part of your work and it is "half done" (rekonq settings dialog will crash this way).

I also found some other things to fix and a bug on tab close. Basically, sometimes keys are not deleted when you close the tab and they are active. Pushed "AccessKeys" branch on rekonq git to show you things to fix.


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103601/#review9699
-----------------------------------------------------------


On Jan. 9, 2012, 7:10 p.m., Marc Deop wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103601/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2012, 7:10 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> Ported accesskeys navigation from the Arora project into rekonq
> 
> 
> Diffs
> -----
> 
>   src/rekonq.kcfg bfaece5 
>   src/settings/settings_general.ui 7e250c4 
>   src/webview.h 95f27f1 
>   src/webview.cpp 8a4cc4b 
> 
> Diff: http://git.reviewboard.kde.org/r/103601/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> AccessKeys
>   http://git.reviewboard.kde.org/r/103601/s/386/
> AccessKey following colorscheme
>   http://git.reviewboard.kde.org/r/103601/s/411/
> 
> 
> Thanks,
> 
> Marc Deop
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120111/0ebda479/attachment.html>