[rekonq] Review Request: Let the User to Load Different URL than the first item of the completetion widget

[Furkan Üzümcü]

> On Jan. 10, 2012, 6:05 p.m., Andrea Diamantini wrote:
> > To say the truth I prefer actual logic, where the "guessing part" is when user types, while when he clicks he just knows what url will be loaded.

You still know wht will be loaded. The old way kind of restricts user. He has to press down a few times to load the URL he/she wants. Just try it for yourself. This really annoys me.


- Furkan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103652/#review9715
-----------------------------------------------------------


On Jan. 10, 2012, 10:27 a.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103652/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2012, 10:27 a.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> Currently, when you type something in the URL bar the completetion widget pops up and activates the first item. And you can't load the URL typed in when you hit enter. Rekonq loads the actvated item. This patch fixes that issue. When you reached the index zero if you go up again the last item gets deactivated and you can load the typed string.
> 
> 
> Diffs
> -----
> 
>   src/urlbar/completionwidget.h 517a7ea 
>   src/urlbar/completionwidget.cpp b349041 
>   src/urlbar/urlbar.h 2d158ff 
>   src/urlbar/urlresolver.h 167ee28 
>   src/urlbar/urlresolver.cpp 5bf2ee6 
> 
> Diff: http://git.reviewboard.kde.org/r/103652/diff/diff
> 
> 
> Testing
> -------
> 
> Compiles and works
> 
> 
> Thanks,
> 
> Furkan Üzümcü
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120110/06c7d38e/attachment-0001.html>