[rekonq] Review Request: Allows web navigation through keyboard

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103601/#review9670
-----------------------------------------------------------



src/rekonq.kcfg
<http://git.reviewboard.kde.org/r/103601/#comment7958>

    This should be "accessKeysEnabled". Yes, I'm seeing the "enableViShortcuts" just 3 lines up. It has to be fixed...



src/webview.h
<http://git.reviewboard.kde.org/r/103601/#comment7957>

    You probably forgot to remove this bool


- Andrea Diamantini


On Jan. 7, 2012, 4:38 p.m., Marc Deop wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103601/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2012, 4:38 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> Ported accesskeys navigation from the Arora project into rekonq
> 
> 
> Diffs
> -----
> 
>   src/rekonq.kcfg bfaece5 
>   src/settings/settings_general.ui 7e250c4 
>   src/webview.h eabe10a 
>   src/webview.cpp 28285a0 
> 
> Diff: http://git.reviewboard.kde.org/r/103601/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> AccessKeys
>   http://git.reviewboard.kde.org/r/103601/s/386/
> AccessKey following colorscheme
>   http://git.reviewboard.kde.org/r/103601/s/411/
> 
> 
> Thanks,
> 
> Marc Deop
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120109/ec9b7060/attachment-0001.html>