[rekonq] Review Request: reworking load/stop/reload actions

Andrea Diamantini adjam7 at gmail.com
Sat Jan 7 13:10:09 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103651/
-----------------------------------------------------------

(Updated Jan. 7, 2012, 1:10 p.m.)


Review request for rekonq.


Changes
-------

workaround problem that m_progress is yet 0 or 100 when load starts


Description
-------

Add load action and merge it with stop/reload.

Also clean up API, giving proper names to methods:
- updateActions --> updateHistoryActions
- browserTabLoading(bool) --> currentTabStateChanged()


Diffs (updated)
-----

  src/mainview.h 28185e4 
  src/mainview.cpp 6285159 
  src/mainwindow.h 04a59a1 
  src/mainwindow.cpp 98936e9 
  src/rekonqui.rc 7aeeb56 
  src/urlbar/urlbar.h 2d158ff 
  src/urlbar/urlbar.cpp 8368492 
  src/webpage.cpp 9dee096 
  src/webtab.h c3d3099 
  src/webtab.cpp 9516f83 

Diff: http://git.reviewboard.kde.org/r/103651/diff/diff


Testing
-------


Screenshots
-----------

rekonq load
  http://git.reviewboard.kde.org/r/103651/s/408/
rekonq reload
  http://git.reviewboard.kde.org/r/103651/s/409/


Thanks,

Andrea Diamantini

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120107/e633a40d/attachment.html>


More information about the rekonq mailing list