[rekonq] Review Request: Allows web navigation through keyboard

[Andrea Diamantini]

> On Jan. 2, 2012, 11:06 a.m., Andrea Diamantini wrote:
> > src/webview.h, line 136
> > <http://git.reviewboard.kde.org/r/103601/diff/1/?file=45181#file45181line136>
> >
> >     This variable has no sense. You should set it to be true. You have to remove it and use something like ReKonfig::accessKeyEnabled().

Obviously the comment was: "You just set it to be true".


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103601/#review9436
-----------------------------------------------------------


On Jan. 1, 2012, 3:26 p.m., Marc Deop wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103601/
> -----------------------------------------------------------
> 
> (Updated Jan. 1, 2012, 3:26 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> Ported accesskeys navigation from the Arora project into rekonq
> 
> 
> Diffs
> -----
> 
>   src/webview.h 7ab3acf 
>   src/webview.cpp 8753b7e 
> 
> Diff: http://git.reviewboard.kde.org/r/103601/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> AccessKeys
>   http://git.reviewboard.kde.org/r/103601/s/386/
> 
> 
> Thanks,
> 
> Marc Deop
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120104/e7321482/attachment.html>