[rekonq] Review Request: Include Tab History when Cloning a Tab

David Narváez david.narvaez at computer.org
Sun Feb 26 14:31:09 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104082/
-----------------------------------------------------------

Review request for rekonq.


Description
-------

Implemented through a new loadUrl method that allows for the caller to specify the QWebHistory pointer from where to copy the history. Redirected the original loadUrl slot to use this new method internally. The method returns the WebTab * just in case we need to maninpulate the created tab in the future.


Diffs
-----

  src/application.h 2689e3f 
  src/application.cpp e0570a5 
  src/mainview.cpp 19e5531 

Diff: http://git.reviewboard.kde.org/r/104082/diff/


Testing
-------

1. Open a tab
2. Navigate a couple of pages in the tab
3. Clone the tab
4. Check the history is preserved in the new tab


Thanks,

David Narváez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120226/05edd773/attachment.html>


More information about the rekonq mailing list