[rekonq] Review Request: Fixes the modifier+enter completion (like addition of .com, .org, .net)

[Tirtha Chatterjee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107662/#review23298
-----------------------------------------------------------

Ship it!


Looks good to me!

- Tirtha Chatterjee


On Dec. 11, 2012, 6:21 a.m., Vedant Agarwala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107662/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2012, 6:21 a.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> There was a bug due to which, when we typed a url like "goal" and pressed ctrl+enter, the .com was not appended. Actually, two urls were being opened in quick succession, one with the .com appended, another one without it (taken from the completion list's url).
> 
> This patch fixes it, by not progressing to load the list's url, and stopping after emitting the appended url.
> 
> 
> Diffs
> -----
> 
>   src/urlbar/completionwidget.cpp 04f7bad 
> 
> Diff: http://git.reviewboard.kde.org/r/107662/diff/
> 
> 
> Testing
> -------
> 
> Tested manually. Works.
> 
> 
> Thanks,
> 
> Vedant Agarwala
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20121211/1458094d/attachment.html>