[rekonq] Review Request: Syncing with Google Bookmarks

[Siteshwar Vashisht]

> On April 22, 2012, 9:53 a.m., Andrea Diamantini wrote:
> > No crashes and quite everything working as expected, very very good! Just one problem there; let me explain with an example.
> > I have on google bookmarks two sites: "google" and "rekonq", while locally there are these two: "kde" and "rekonq". Starting google bookmarks sync, "google" site has been added to my local bookmarks (good!) but "kde" site has not been added to google ones: shouldn't bookmarks be fully synced each others?
> >

I fixed it! I have pushed my changes in repository.


- Siteshwar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104673/#review12780
-----------------------------------------------------------


On April 19, 2012, 5:47 p.m., Siteshwar Vashisht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104673/
> -----------------------------------------------------------
> 
> (Updated April 19, 2012, 5:47 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> Adding support for syncing with Google Bookmarks.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 10b57b1 
>   src/sync/googlesynchandler.h PRE-CREATION 
>   src/sync/googlesynchandler.cpp PRE-CREATION 
>   src/sync/sync_google_settings.ui PRE-CREATION 
>   src/sync/sync_host_type.ui 6eb875d 
>   src/sync/syncassistant.h 01b9647 
>   src/sync/syncassistant.cpp 8688d7b 
>   src/sync/synccheckwidget.cpp 9dbf5fc 
>   src/sync/syncgooglesettingswidget.h PRE-CREATION 
>   src/sync/syncgooglesettingswidget.cpp PRE-CREATION 
>   src/sync/synchosttypewidget.cpp 0810182 
>   src/sync/syncmanager.cpp 5766f41 
> 
> Diff: http://git.reviewboard.kde.org/r/104673/diff/
> 
> 
> Testing
> -------
> 
> From menu select :
> 
> Tools -> Sync
> 
> Select bookmarks and click next.
> Select Google Bookmarks
> Follow rest of the directions in wizard.
> 
> 
> Thanks,
> 
> Siteshwar Vashisht
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120422/79dc4c87/attachment.html>