[rekonq] Review Request: Spellcheck support in Rekonq

[Andrea Diamantini]

> On April 19, 2012, 3:58 p.m., Andrea Diamantini wrote:
> > I don't understand these changes. Why aren't we doing inline spell check on strings? I think that it is the unique way to let people use spellcheck. Just check on keyPressEvent if you are on an INPUT/TEXTAREA element on content editable text and if so, check words before spaces.
> 
> Siteshwar Vashisht wrote:
>     I guess we had already discussed this issue. Support for inline spell check will require us to modify QtWebkit sources. I just followed the way KWebKitPart does it. I am not sure how helpful your current suggestion would be in providing full fledged inline spell check.
> 
> Lindsay Mathieson wrote:
>     As Siteshwar said, it can only be done in the QtWebKit sources and has been, but is very unlikely to make its way into KDE. See this discussion here:
>     
>       https://lists.webkit.org/pipermail/webkit-qt/2012-February/002429.html
> 
> Andrea Diamantini wrote:
>     Bah... IMHO, I see what's needed just mixed in this code. Can I please try in this weekend to follow my broken mind before considering this?
> 
> Lindsay Mathieson wrote:
>     How do you intend to display the squiggly red underline for mispelled words?

Yeah, now I see. Anyway, it can be done with easy html + js, I suppose. Anyway, Lindsay, what about merging your code in a forked (qt)webkit1 repo and release it?


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104647/#review12658
-----------------------------------------------------------


On April 17, 2012, 4:59 p.m., Siteshwar Vashisht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104647/
> -----------------------------------------------------------
> 
> (Updated April 17, 2012, 4:59 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> Adding support for spellcheck in Rekonq using Sonnet. Right now spellcheck is not inline and you need to right click text box and select "Spellcheck" to perform checks.
> 
> 
> Diffs
> -----
> 
>   src/webview.h 3ae9b7e 
>   src/webview.cpp d2e351c 
> 
> Diff: http://git.reviewboard.kde.org/r/104647/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> 
> Thanks,
> 
> Siteshwar Vashisht
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120422/e27cb2e3/attachment.html>