[rekonq] Review Request: Move Tab Preview to WebTab

[David Narváez]

> On April 15, 2012, 10:14 a.m., Andrea Diamantini wrote:
> > src/webtab.cpp, line 46
> > <http://git.reviewboard.kde.org/r/104517/diff/2/?file=56616#file56616line46>
> >
> >     I think webtab should NOT depend on tabbar. So the tabPreview() method should return a "fixed size" pixmap of the tab, letting the classes wanting use it resize at need.
> >     
> >     What do you think about?

I agree the dependency on tabbar.h is odd. What about tabPreview(int width, int height)?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104517/#review12462
-----------------------------------------------------------


On April 14, 2012, 12:44 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104517/
> -----------------------------------------------------------
> 
> (Updated April 14, 2012, 12:44 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> Let the WebTab class calculate its own preview, so that it can be used elsewhere in the code. Notice that it will return a null QPixmap in case the page is loading, which is currently the only case when we consider it invalid to produce a preview, but it can later be extended to whatever rule we want right at the WebTab class.
> 
> 
> Diffs
> -----
> 
>   src/tabpreviewpopup.cpp 4466868 
>   src/webtab.h 92ae2eb 
>   src/webtab.cpp 718d8b9 
> 
> Diff: http://git.reviewboard.kde.org/r/104517/diff/
> 
> 
> Testing
> -------
> 
> 1. Load two or more tabs in Rekonq
> 2. Wait for them to load
> 3. Mouse over any tab and see the preview
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120415/5a234aef/attachment.html>