[rekonq] Review Request: Move Tab Preview to WebTab
David Narváez
david.narvaez at computer.org
Sat Apr 14 12:44:18 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104517/
-----------------------------------------------------------
(Updated April 14, 2012, 12:44 p.m.)
Review request for rekonq.
Changes
-------
This is the patch as it will be committed, fixed the naming issue.
Description
-------
Let the WebTab class calculate its own preview, so that it can be used elsewhere in the code. Notice that it will return a null QPixmap in case the page is loading, which is currently the only case when we consider it invalid to produce a preview, but it can later be extended to whatever rule we want right at the WebTab class.
Diffs (updated)
-----
src/tabpreviewpopup.cpp 4466868
src/webtab.h 92ae2eb
src/webtab.cpp 718d8b9
Diff: http://git.reviewboard.kde.org/r/104517/diff/
Testing
-------
1. Load two or more tabs in Rekonq
2. Wait for them to load
3. Mouse over any tab and see the preview
Thanks,
David Narváez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120414/c18b0edd/attachment.html>
More information about the rekonq
mailing list