[rekonq] Review Request: Uncheck Private Browsing if the user canceled the action

Andrea Di Menna ninniuz at gmail.com
Fri Sep 30 15:06:12 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102747/
-----------------------------------------------------------

Review request for rekonq and Andrea Diamantini.


Description
-------

After the user checks the Private Browsing setting in the menu, a KMessageBox is created.
If the user presses on the Cancel button the checkbox is kept checked, leading to inconsistencies between the status of the setting and the checkox status itself.
In the diff the checkbox is unchecked if the return value of the KMessageBox is anything but Continue.


Diffs
-----

  src/application.cpp 985de81 

Diff: http://git.reviewboard.kde.org/r/102747/diff/diff


Testing
-------

Compiled and working


Thanks,

Andrea Di Menna

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110930/bb597a52/attachment.html>


More information about the rekonq mailing list