[rekonq] Review Request: Remove QPoint from downloadAllContentsWithKGet slot to have KGet list links from a page

Andrea Diamantini adjam7 at gmail.com
Tue Sep 27 07:18:15 UTC 2011



> On Sept. 26, 2011, 3:56 p.m., Andrea Diamantini wrote:
> > It is working well here. Moreover, your patch does really change nothing: you probably just need to "git checkout -f && make install".
> 
> Andrea Di Menna wrote:
>     I forced the checkout to master and built again.
>     Everything is working ok if I press the KGet icon in the UrlBar but not if I select the "List All Links" item in the context menu.
>     If this working for you?

Right! Now I see it, many thanks for :)


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102708/#review6838
-----------------------------------------------------------


On Sept. 26, 2011, 11:02 a.m., Andrea Di Menna wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102708/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2011, 11:02 a.m.)
> 
> 
> Review request for rekonq, Felix Rohrbach and Andrea Diamantini.
> 
> 
> Description
> -------
> 
> Rekonq has the ability to pass a list of links to KGet to enable batch download.
> The feature was not working on master and the debug output was showing that no WebPage::downloadAllContentsWithKGet existed.
> I have removed the QPointe from the slot definition and when connecting to it.
> It is working now.
> 
> 
> Diffs
> -----
> 
>   src/urlbar/urlbar.cpp ed00c84 
>   src/webpage.h 609141f 
>   src/webpage.cpp 17d791c 
> 
> Diff: http://git.reviewboard.kde.org/r/102708/diff/diff
> 
> 
> Testing
> -------
> 
> Compiled and working
> 
> 
> Thanks,
> 
> Andrea Di Menna
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110927/9b8ab3da/attachment.html>


More information about the rekonq mailing list