[rekonq] Review Request: Change UserAgent descriptions to use X-KDE-UA-SYS* properties from .desktop files instead of Name prop

Andrea Di Menna ninniuz at gmail.com
Mon Sep 26 17:19:17 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102712/
-----------------------------------------------------------

Review request for rekonq.


Description
-------

I have changed the UA descriptions to be composed by X-KDE-UA-SYS* properties from .desktop files since the current method does not take into account localization issues.
Currently the UA description e.g. in Italian are messed up as the UADescription prefix has been translated in the IT .desktop files causing the QString replace to fail.
It should be better to compose the description using X-KDE-UA-SYSNAME and X-KDE-UA-SYSRELEASE which will not be translated.


Diffs
-----

  src/useragent/useragentinfo.cpp 8287110 

Diff: http://git.reviewboard.kde.org/r/102712/diff/diff


Testing
-------

Compiled and working.


Thanks,

Andrea Di Menna

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110926/56538bc2/attachment.html>


More information about the rekonq mailing list