[rekonq] Review Request: Remove a minor focus glitch appearing when loading a favorite page via shortcut

[Thomas Murach]

> On Sept. 25, 2011, 10:18 a.m., Andrea Diamantini wrote:
> > uhm... I tried ctrl + t && ctrl + 1. I have web page focus here. What about other people?

I think you did something different than what I meant: When I start rekonq I only see my favorite page tab. When just pressing ctrl+t and ctrl+1, everything works fine, just like in your case. But when you start rekonq, press for instance ctrl+2 and then ctrl+t && ctrl+1, my patch seems to be needed. Can you confirm that?


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102695/#review6792
-----------------------------------------------------------


On Sept. 25, 2011, 2:09 a.m., Thomas Murach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102695/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2011, 2:09 a.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> Some time ago the possibility to load favorite pages via shortcut (ctrl+number) was added. I noticed a small inconvenience: when opening a new tab via "ctrl+t" and then loading a favorite page, the new tab doesn't seem to have the focus, therefore scrolling via arrow keys isn't possible. This patch should fix that
> 
> 
> Diffs
> -----
> 
>   src/mainview.cpp 89c380d 
> 
> Diff: http://git.reviewboard.kde.org/r/102695/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas Murach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110925/ce80a791/attachment.html>