[rekonq] Review Request: Add a "Share URL via email" action to rekonq tools
Andrea Diamantini
adjam7 at gmail.com
Fri Sep 23 14:47:47 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102674/#review6766
-----------------------------------------------------------
Uhm... while I like the idea and the code (thanks, Andrea!!) I don't think such an action should be exposed in rekonq tools menu, but just in webview contextual one.
- Andrea
On Sept. 22, 2011, 1:06 p.m., Andrea Di Menna wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102674/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2011, 1:06 p.m.)
>
>
> Review request for rekonq and Felix Rohrbach.
>
>
> Summary
> -------
>
> The bug was requesting a way to share the current URL via email.
> The patch sets up a new action in the rekonq tools to enable sharing the current URL with the default mail application.
> The URL is shared in the body of a new email.
>
> *NOTE*
> I do not have a KDE git account to commit.
>
>
> This addresses bug 226349.
> /show_bug.cgi?id=226349
>
>
> Diffs
> -----
>
> src/mainwindow.h 3144222
> src/mainwindow.cpp 528ec21
> src/rekonqui.rc 94bfb4a
>
> Diff: http://git.reviewboard.kde.org/r/102674/diff
>
>
> Testing
> -------
>
> Compiled and working
>
>
> Thanks,
>
> Andrea
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110923/cc01a9f1/attachment.html>
More information about the rekonq
mailing list