[rekonq] Review Request: Add a "Share URL via email" action to rekonq tools

[Felix Rohrbach]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102674/#review6725
-----------------------------------------------------------


I like it :) It might be a corner use case, but it doesn't disturb users not using this feature and it doesn't add much new code. A few minor issues I found are listed below. Of course, this can only be included after the 0.8 release.


src/mainwindow.h
<http://git.reviewboard.kde.org/r/102674/#comment5932>

    You have a trailing space here. It's not a big issue, but we don't like them that much. Could you remove it? For the future: most editors have an option to remove those spaces automatically, so you don't need to care about them anymore :).



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/102674/#comment5931>

    Another trailing space.



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/102674/#comment5933>

    You can use triggered() instead of triggered(bool) here



src/rekonqui.rc
<http://git.reviewboard.kde.org/r/102674/#comment5934>

    Here, the indentation is not right. Did you maybe use tabs instead of spaces? (We prefer to always use spaces, your editor should have an option for this, too)


- Felix


On Sept. 22, 2011, 10:58 a.m., Andrea Di Menna wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102674/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2011, 10:58 a.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> The bug was requesting a way to share the current URL via email.
> The patch sets up a new action in the rekonq tools to enable sharing the current URL with the default mail application.
> The URL is shared in the body of a new email.
> 
> 
> This addresses bug 226349.
>     /show_bug.cgi?id=226349
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.h 3144222 
>   src/mainwindow.cpp 528ec21 
>   src/rekonqui.rc 94bfb4a 
> 
> Diff: http://git.reviewboard.kde.org/r/102674/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrea
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110922/5fa0b21a/attachment.html>