[rekonq] Review Request: Don't crash if the rekonqui.rc file can't be found

Johannes Tröscher fritz_van_tom at hotmail.com
Wed Sep 21 14:47:53 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102673/#review6709
-----------------------------------------------------------

Ship it!


good idea, please merge!


src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/102673/#comment5930>

    i think this is already imported through rekonq_defines.h


- Johannes


On Sept. 21, 2011, 2:47 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102673/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2011, 2:47 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Before, if a user ran rekonq locally without ever installing it, the missing rekonqui.rc file resulted in a crash, without informing the user about the problem. With this patch, the user gets a wrong interface and a debug line about the missing file.
> 
> 
> This addresses bug 282474.
>     /show_bug.cgi?id=282474
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.cpp 12ecf7a 
> 
> Diff: http://git.reviewboard.kde.org/r/102673/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110921/798621ca/attachment.html>


More information about the rekonq mailing list